Make all src functions and structs crate-private#2841
Merged
kinnison merged 1 commit intorust-lang:masterfrom Nov 8, 2021
Merged
Make all src functions and structs crate-private#2841kinnison merged 1 commit intorust-lang:masterfrom
kinnison merged 1 commit intorust-lang:masterfrom
Conversation
Signed-off-by: hi-rustin <rustin.liu@gmail.com> Fmt code Signed-off-by: hi-rustin <rustin.liu@gmail.com>
0xPoe
force-pushed
the
rustin-patch-src
branch
from
50fa83c to
8d61aa3
Compare
Member
Author
|
@rbtcollins @kinnison Could you please take a look when you have time? Thanks! ❤️ |
rbtcollins
reviewed
Aug 29, 2021
Member
Author
|
@kinnison Could you please take a look? Thanks! |
kinnison
approved these changes
Nov 8, 2021
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
I think this looks like a good improvement to our ability to see what's going on, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #2829